add docs, cleanup dead code

drupal-graphql · Sep 21, 2023 · 60b9010 · 60b9010
1 parent b6e8d9b
commit 60b9010
Show file tree

Hide file tree

Showing 4 changed files with 53 additions and 17 deletions.
diff --git a/tests/src/Kernel/DataProducer/Entity/Fields/Image/ImageDerivativeTest.php b/tests/src/Kernel/DataProducer/Entity/Fields/Image/ImageDerivativeTest.php
@@ -20,6 +20,34 @@ class ImageDerivativeTest extends GraphQLTestBase {
    */
   protected static $modules = ['image', 'file'];
 
+  /**
+   * The file system URI under test.
+   *
+   * @var string
+   */
+  protected $file_uri;
+
+  /**
+   * The file entity mock.
+   *
+   * @var \Drupal\file\FileInterface
+   */
+  protected $file;
+
+  /**
+   * The image style for testing.
+   *
+   * @var \Drupal\image\Entity\ImageStyle
+   */
+  protected $style;
+
+  /**
+   * A file entity mock that returns FALSE on access checking.
+   *
+   * @var \Drupal\file\FileInterface
+   */
+  protected $file_not_accessible;
+
   /**
    * {@inheritdoc}
    */
@@ -34,8 +62,8 @@ public function setUp(): void {
 
     $this->file->method('getFileUri')->willReturn($this->file_uri);
     $this->file->method('access')->willReturn((new AccessResultAllowed())->addCacheTags(['test_tag']));
-    $this->file->width = 600;
-    $this->file->height = 400;
+    @$this->file->width = 600;
+    @$this->file->height = 400;
 
     $this->style = ImageStyle::create(['name' => 'test_style']);
     $effect = [

diff --git a/tests/src/Kernel/DataProducer/Entity/Fields/Image/ImageUrlTest.php b/tests/src/Kernel/DataProducer/Entity/Fields/Image/ImageUrlTest.php
@@ -14,12 +14,32 @@
  */
 class ImageUrlTest extends GraphQLTestBase {
 
+  /**
+   * The file entity mock.
+   *
+   * @var \Drupal\file\FileInterface
+   */
+  protected $file;
+
+  /**
+   * A file entity mock that returns FALSE on access checking.
+   *
+   * @var \Drupal\file\FileInterface
+   */
+  protected $file_not_accessible;
+
+  /**
+   * The generated file URI.
+   *
+   * @var string
+   */
+  protected $fileUri;
+
   /**
    * {@inheritdoc}
    */
   public function setUp(): void {
     parent::setUp();
-    $this->dataProducerManager = $this->container->get('plugin.manager.graphql.data_producer');
 
     $this->fileUri = \Drupal::service('file_url_generator')->generateAbsoluteString('public://test.jpg');
 

diff --git a/tests/src/Kernel/DataProducer/EntityMultipleTest.php b/tests/src/Kernel/DataProducer/EntityMultipleTest.php
@@ -42,18 +42,6 @@ class EntityMultipleTest extends GraphQLTestBase {
   public function setUp(): void {
     parent::setUp();
 
-    $this->entity = $this->getMockBuilder(NodeInterface::class)
-      ->disableOriginalConstructor()
-      ->getMock();
-
-    $this->entity_interface = $this->getMockBuilder(EntityInterface::class)
-      ->disableOriginalConstructor()
-      ->getMock();
-
-    $this->user = $this->getMockBuilder(UserInterface::class)
-      ->disableOriginalConstructor()
-      ->getMock();
-
     $content_type = NodeType::create([
       'type' => 'lorem',
       'name' => 'ipsum',

diff --git a/tests/src/Kernel/Framework/PersistedQueriesTest.php b/tests/src/Kernel/Framework/PersistedQueriesTest.php
@@ -46,11 +46,11 @@ protected function setUp(): void {
     $this->mockResolver('Link', 'title', 'Ecosia');
 
     /** @var \Drupal\graphql\Plugin\DataProducerPluginManager $manager */
-    $manager = $this->container->get('plugin.manager.graphql.persisted_query');
+    /*$manager = $this->container->get('plugin.manager.graphql.persisted_query');
 
     $this->plugin_one = $manager->createInstance('persisted_query_plugin_one');
     $this->plugin_two = $manager->createInstance('persisted_query_plugin_two');
-    $this->plugin_three = $manager->createInstance('persisted_query_plugin_three');
+    $this->plugin_three = $manager->createInstance('persisted_query_plugin_three');*/
   }
 
   /**