Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Change djinni's generated Java files to use interfaces #406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ggdabuh
Copy link

@ggdabuh ggdabuh commented Sep 19, 2018

This pull request is related to #390.
The idea is to use interfaces rather that classes as, anyway, the marshaling layer is ready for that.
This is a breaking change since users will need to update their overrides.

@artwyman
Copy link
Contributor

To be clear for readers, is about using abstract interfaces for generated container types like list and map when used in records, arguments, and returns. This isn't about what Djinni calls interfaces.

A few procedural things:

  • You should re-generate the test suite and example code so we can see how your generator change affects the generated code for these examples. You should also ensure the test suite passes (if you can make all from the root of the repo you're all set).
  • This would be a breaking change for existing users, so I think it needs to be exposed as a configurable feature via command-line, not a default behavior change

@xianwen
Copy link

xianwen commented Dec 26, 2018

Hi, @ggdabuh:
I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/
Thanks a lot!

@artwyman artwyman self-assigned this Apr 9, 2019
@artwyman
Copy link
Contributor

artwyman commented Apr 9, 2019

This repo isn't going to be adding any new features so I'm putting this PR on hold.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants