Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle Plugin so we can have knowledge of how to disable config cache #152

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

joshafeinberg
Copy link
Member

In order to call notCompatibleWithConfigurationCache we need to be on at least Gradle 7.4 so we updated the plugin and disabled config cache for any custom tasks made using AMD

#150

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #152 (9f112b4) into main (6c2b902) will decrease coverage by 0.22%.
The diff coverage is 22.22%.

❗ Current head 9f112b4 differs from pull request most recent head 9c5040e. Consider uploading reports for the commit 9c5040e to get more accurate results

@@             Coverage Diff              @@
##               main     #152      +/-   ##
============================================
- Coverage     53.69%   53.47%   -0.23%     
  Complexity       68       68              
============================================
  Files            13       13              
  Lines           514      518       +4     
  Branches         97       99       +2     
============================================
+ Hits            276      277       +1     
- Misses          212      214       +2     
- Partials         26       27       +1     
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 40.65% <ø> (ø)
...ctedmoduledetector/AffectedModuleDetectorPlugin.kt 50.00% <22.22%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2b902...9c5040e. Read the comment docs.

@joshafeinberg joshafeinberg merged commit 974485f into main Jul 15, 2022
@joshafeinberg joshafeinberg deleted the jfein/disable-config-cache branch July 15, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants