TAC模式读已提交的隔离级别bug修复 #364
Merged
TAC模式读已提交的隔离级别bug修复 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #364 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 442 443 +1
Lines 8621 8659 +38
Branches 1417 1421 +4
======================================
- Misses 8621 8659 +38
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cherrylzhao
reviewed
Aug 24, 2023
| */ | ||
| String makePaymentWithReadCommitted(Order order); | ||
| String makePaymentWithReadCommitted(Order order, int type); |
There was a problem hiding this comment.
type 的含义不明确，代码中避免直接用1，2进行区分，建议使用enum
cherrylzhao
reviewed
Aug 24, 2023
| @Getter | ||
| public enum ReadCommittedTransactionEnum { | ||
|
|
||
| READ_COMMITTED_TRANSACTION_ALL(1, "读已提交隔离级别的事务, 包括更新、查询操作"), |
There was a problem hiding this comment.
建议替换为TRANSACTION_READ_WRITE
cherrylzhao
reviewed
Aug 24, 2023
|
|
||
| READ_COMMITTED_TRANSACTION_ALL(1, "读已提交隔离级别的事务, 包括更新、查询操作"), | ||
|
|
||
| READ_COMMITTED_TRANSACTION_JUST_SELECT(2, "读已提交隔离级别的事务, 只有查询操作"); |
There was a problem hiding this comment.
建议替换为TRANSACTION_READ_ONLY
cherrylzhao
pushed a commit
that referenced
this pull request
Oct 24, 2023
* TAC模式读已提交的隔离级别bug修复, 读隔离查询时只需要检查全局锁, 增加重试机制, 修改对应的测试demo。 * 优化tac demo代码, 使用enum代替int值来区分代码逻辑 * 优化tac demo中enum的命名
cherrylzhao
pushed a commit
that referenced
this pull request
Oct 24, 2023
* TAC模式读已提交的隔离级别bug修复, 读隔离查询时只需要检查全局锁, 增加重试机制, 修改对应的测试demo。 * 优化tac demo代码, 使用enum代替int值来区分代码逻辑 * 优化tac demo中enum的命名
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn clean install -Dmaven.javadoc.skip=true.for issue #363