Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands refactoring rfc #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Commands refactoring rfc #21

wants to merge 1 commit into from

Conversation

dejanb
Copy link
Member

@dejanb dejanb commented Nov 9, 2022

No description provided.

@dejanb dejanb requested review from lulf and ctron November 9, 2022 11:56
lulf
lulf approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Maybe mention how this affects/deprecates earlier RFCs?

ctron
ctron approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what might make sense is to draft an OpenAPI spec of the new (internal) API for the service.

@dejanb
Copy link
Member Author

dejanb commented Nov 9, 2022 •
edited
Loading

Nice work! Maybe mention how this affects/deprecates earlier RFCs?

I don't think we have any. There is no RFC for current implementation of commands.

@dejanb
Copy link
Member Author

dejanb commented Nov 9, 2022

I guess what might make sense is to draft an OpenAPI spec of the new (internal) API for the service.

Let's keep this one as draft for now. I would like to play with code first and then create API spec and more formal interaction diagrams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron approved these changes

@lulf lulf lulf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dejanb @lulf @ctron