Add support for Rust stable #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @petekubiak and @jamessizeland have managed to update to Rust Stable in the following PR: #19 |
|
Confirmed, ector is now supported on stable as of the merging of #19. The proc_macro_diagnostic feature is retained for nightly builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like aa15f8e removed most of the nightly dependencies, but this
featurein ector-macros is still blocking support for stable.Would enabling this feature with this
cfg(nightly)throughbuild.rsbe an acceptable mechanism for supporting ector on stable Rust, while maintaining support for this nightly feature?