-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bug): fix bug where footer not attached to keyboard in some device and update flutter_keyboard_visibility
#35
Open
ryanaidilp
wants to merge
14
commits into
drogel:master
Choose a base branch
from
ryanaidilp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−55
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
15cd567
chore(packages): update package number and version with sdk version
ryanaidilp dcaf0f2
chore(example): update sdk version constraints
ryanaidilp 8169e44
chore(gradle): update to gradle 7.5
ryanaidilp 8cb3998
chore(gradle): update compile and target sdk version to 31
ryanaidilp b147f93
chore(gradle): update gradle version and kotlin version
ryanaidilp d7962c0
chore(manifest): add exported=true for android 12 support
ryanaidilp db3fa05
refactor(shouldrelayout): check for should relayout
ryanaidilp 1e3c58a
Merge branch 'drogel:master' into master
ryanaidilp 2cfa757
chore(packages): bump flutter_keyboard_visibility to 6.0.0
ryanaidilp 49cd902
refactor(widget): use widget binding observer
ryanaidilp f21dfab
refactor(linter): remove unused linter rule
ryanaidilp 301c7a5
feat(data): create keyboard animation data class
ryanaidilp 653a08d
refactor(widget): use super parameter builder
ryanaidilp a34b5bb
fix(keyboard_attachable): fix issue where sometimes widget not attached
ryanaidilp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import 'package:flutter/material.dart'; | ||
|
||
@immutable | ||
class KeyboardAnimationData { | ||
const KeyboardAnimationData({ | ||
this.bottomInset = 0, | ||
this.animationBegin = 0, | ||
}); | ||
|
||
final double bottomInset; | ||
final double animationBegin; | ||
|
||
KeyboardAnimationData copyWith({ | ||
double? bottomInset, | ||
double? animationBegin, | ||
}) => | ||
KeyboardAnimationData( | ||
bottomInset: bottomInset ?? this.bottomInset, | ||
animationBegin: animationBegin ?? this.animationBegin, | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class encapsulates
bottomInset
andanimationBegin
, allowing these properties to be bundled together. By encapsulating them within this class, we facilitate their use in aValueNotifier
, promoting a cleaner and more efficient way to manage and react to changes in these values.Example:
This approach simplifies the tracking of keyboard animation data changes, enabling more responsive and straightforward UI updates.