Feature/floating maker changes #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handling potential exceptions on floatingMaker - Canceling and placing all orders at once instead of serially - that will make it cleaner to set up multiple orders later.
0xbigz
reviewed
Sep 5, 2023
0xbigz
reviewed
Sep 5, 2023
| } catch (e) { | ||
| console.log('Error placing new orders'); | ||
| console.error(e); | ||
| console.log('----'); |
There was a problem hiding this comment.
what error are you typically hitting that leads to this?
There was a problem hiding this comment.
Usually it seems to be "This transaction has already been processed" (at simulation time) but I've seen the rare timeout.
0xbigz
reviewed
Sep 5, 2023
0xbigz
reviewed
Sep 5, 2023
src/bots/floatingMaker.ts
Outdated
| const orderSizeShort = | ||
| exposureDir == PositionDirection.SHORT | ||
| ? orderSizeCurrent | ||
| : orderSizeOther; |
There was a problem hiding this comment.
do you think it'd be better/safer if orderSize was specified in quote and then floored to the base step size?
There was a problem hiding this comment.
Do you mean as an API option?
We can now configure the timing and the order size
I'm getting some errors on testing with all markets, and this makes it easier to narrow down what the issue is. It's also unlikely anyone would like to test all markets at once.
The bot was canceling existing orders when one side had been fully filled, *except* for SOL-PERP, in which case it always canceled them even if they were partially filled. This had the effect that a SOL_PERP position grew rapidly unbalanced, regardless of how much the market was moving. See issue drift-labs#66.
Trivial implementation, see comments on the code for details. This addresses issue drift-labs#65.
Two changes: - Canceling all PERP orders on start, in case there were any leftover orders by a previous instance; - Canceling all orders on for a market with a single instruction. See comments on patch for a possible improvement.
- Moved maxPositionExposure to the configuration, it makes no sense to keep it hardcoded. - Updated comments around the way it behaves when approaching the maximum exposure, since the ones there did not match the implementation (and the bot wasn't handling it before). - Removed unused constant RESTRICT_POSITION_SIZE. If you don't want it restricted, simply use a high value as the maximum exposure.
- Moved all order related calculations into the `if` we are placing orders block. - Fixed a mistaken log on the remaining allowance.
It's possible that the position has exceeded the total allowed value due to multiple reasons: configuration changes, collateral value changes, violent position swings, or simply user-executed transfers.
Decided to handle what happens if we get too lopsided, and we need to start closing one side. We identify that case by the proportion being such that one of the sides would be smaller than the minimum order size for the market. In that case, we *will* allow a single order on the other side.
ricardojmendez
force-pushed
the
feature/floating-maker-changes
branch
from
a29d7d6 to
b9212da
Compare
|
Fixed some issues, and added a few commits, including implementing bias order skewing and handling positions in a "closing" state, as well as cleaning up outdated comments. |
|
Closing, since the PR is old and the code has drifted. I may re-submit after a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple changes to floatingMaker, including adding configuration options, avoiding crashes on exceptions, and handling issues #65 and #66.