Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#84] Fixed [tags] token using all tags instead of latest. #85

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Apr 17, 2024

Checklist before requesting a review

closes #84

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 36.51%. Comparing base (36ac23d) to head (aa28439).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Git/ArtifactGitRepository.php 0.00% 4 Missing ⚠️
src/Commands/ArtifactCommand.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   36.83%   36.51%   -0.32%     
==========================================
  Files           6        6              
  Lines         467      471       +4     
==========================================
  Hits          172      172              
- Misses        295      299       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk changed the title [#84] Get tags point to HEAD. [#84] Fixed [tags] token using all tags instead of latest. Apr 17, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 2cf0a91 into main Apr 17, 2024
8 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/get-token-tags branch April 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags deployment fails
3 participants