Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#42] Converted to standalone Symfony Console CLI app #59

Merged
merged 36 commits into from
Mar 8, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Feb 26, 2024

Checklist before requesting a review

closes #42

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 changed the title Converted to standalone Symfony Console CLI app [#42] Converted to standalone Symfony Console CLI app Feb 26, 2024
@tannguyen04
Copy link
Contributor Author

Hi @AlexSkrypnyk

Could you please look into why ci/build is failing ? But composer lint in Github Action is working.
Also please look into why Test PHP / deploy is failing.

Thank you.

@AlexSkrypnyk
Copy link
Member

@tannguyen04
Thank you for working on this.

Could you please update the GHA test workflow to run with --debug (or whatever that flag is) to show the reason for the failure.

Currently, it just says:

Deployment failed.
Error: ] Error occurred while pushing branch "mode-force-push-github": Unable to push local branch "mode-force-push-github-artifact" to "dst" remote branch "mode-force-push-github":
Error: Process completed with exit code 1.

@AlexSkrypnyk
Copy link
Member

@tannguyen04
I've updated CI in another PR and added some advanced deployment testing.
I've also updated this PR and resolved conflicts.

The implementation here is not what I was after: it is currently a wrapper around Robo instead of being a standalone application.

Can you please make the following changes on this PR branch:

  • Replace GitTrait with a package https://github.com/cpliakas/git-wrapper
  • Remove Robo altogether and refactor the CLI command file to use the logic in ArtifactTrait directly - there should not be any traits - they were only used to make it work with Robo.
  • Update tests as necessary to work with the new command. Note that the Functional tests could use the same git wrapper package as the command itself.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/convert-to-symfony-app branch from 61dac9b to 8d7ac25 Compare February 27, 2024 12:28
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/convert-to-symfony-app branch from 8d7ac25 to 547e6dd Compare February 27, 2024 12:30
@tannguyen04 tannguyen04 marked this pull request as draft March 5, 2024 03:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 1.27389% with 155 lines in your changes are missing coverage. Please review.

Project coverage is 6.50%. Comparing base (b714d87) to head (4722e36).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Artifact.php 3.17% 61 Missing ⚠️
src/Commands/ArtifactCommand.php 0.00% 58 Missing ⚠️
src/GitTrait.php 0.00% 33 Missing ⚠️
src/FilesystemTrait.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #59      +/-   ##
========================================
- Coverage   7.63%   6.50%   -1.13%     
========================================
  Files          4       5       +1     
  Lines        380     461      +81     
========================================
+ Hits          29      30       +1     
- Misses       351     431      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk marked this pull request as ready for review March 8, 2024 20:24
@AlexSkrypnyk AlexSkrypnyk merged commit b5c19a7 into main Mar 8, 2024
9 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/convert-to-symfony-app branch March 8, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to a Symfony console app
3 participants