This repository has been archived by the owner on May 31, 2019. It is now read-only.
Make Counter thread-safe. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from unittest2 import TestCase | ||
|
|
||
| from yunomi.core.counter import Counter | ||
|
|
||
|
|
||
| class CounterTests(TestCase): | ||
| _counter = Counter() | ||
| def setUp(self): | ||
| _RLock_patcher = mock.patch('yunomi.core.counter.RLock') |
There was a problem hiding this comment.
Any particular reason why this call does not use spec_set? That should be IMHO always used when using mock – or at least spec. cf. http://blog.futurefoundries.com/2013/02/mock-assurances.html
Also why the _-prefix for a local variable?
There was a problem hiding this comment.
I was under the apparently mistaken impression that mock.patch always spec'd the object it was patching.
|
The code LGTM—my OCD aside. |
…re is no opportunity for re-entrancy.
|
LGTM |
|
I want to write some solid benchmarks but I think this would be better with: https://github.com/dreid/atomiclong |
|
@dreid Are you still maintaining this lib? All these PRs still open from 2013 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.