Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.0取り込み #4

Merged
merged 98 commits into from
Nov 30, 2023
Merged

v1.3.0取り込み #4

merged 98 commits into from
Nov 30, 2023

Conversation

Egliss
Copy link

@Egliss Egliss commented Nov 29, 2023

1.3.0までの差分取り込み

  • 新規ファイルのnamespaceを更新 2e68c81

AngusJohnson and others added 30 commits March 28, 2023 23:13
Changed a parameter in ExecuteRectClip() (C++ only) (AngusJohnson#471)
Fixed a crash in Clipper.Offset when not paths are submitted before offsetting. (C#, Del.)(AngusJohnson#476)
* Add googlebenchmark and improve the stripduplicates

* Moved file to CPP/Utils/CommonUtils.h
…nson#485)

Further tweaks to ClipperOffset class (AngusJohnson#482)
clipper.core.h - made PI a conditional define (AngusJohnson#478)
  fixed a minor bug constructing Polytree structure.
  tidied code used in constructing Polytrees
Clipper.RectClip
  fixed a minor bug
Fixed a minor bug in Clipper.Engine.cs (AngusJohnson#510)
Fixed minor bugs in Clipper.Core.cs
  added support for variable offsets (AngusJohnson#511)
  further reduced extraneous vertices in solutions (AngusJohnson#499)
ClipperEngine
  Fixed a minor bug with polytrees (AngusJohnson#520)
  to RectClip and RectClipLines respectively.
Fixed minor C# offsetting bugs
Fixed RectClipLines bug (C# only) (AngusJohnson#530)
…#568)

Fixed significant bugs in Polytree path ownership (AngusJohnson#584, D.AngusJohnson#576)
Fixed a minor bug in RectClip (AngusJohnson#586)
…eaders (AngusJohnson#602)

* Add test case that fails

* Fix problem that may appear when including Windows.h before clipper headers
AngusJohnson and others added 26 commits November 8, 2023 21:28
Minor changes to clipper.export.h
  Renamed DisposeExportedCPaths64 to DisposeArray64
  Renamed DisposeExportedCPathsD to DisposeArrayD
  Tidied up code documentation
* Add failing simplification test

A slightly wiggly line from (0,0) to (0,100), which we expect to
simplify to a straight line of length 100 with just the two endpoints
remaining.

Instead it simplifies to a much shorter line.

* Don't recompute distance for open endpoint
Caution: Fixed SimplifyPaths function in Delphi with reversed boolean parameter.
Minor code tidy to SimplifyPaths function.
Reminder: Offsetting open path 'delta' behaviour also changed (ie doubled) recently.
  Changes since ver 1.2.3 include:
  1. Important: Offsetting open path behaviour has changed.
     The delta now behaves as it did in Clipper1 (See Issue AngusJohnson#707)
  2. Important: Data structures of exported values in clipper.export.h have changed.
  3. Minor bugfixes to PolyTree nesting (AngusJohnson#679, AngusJohnson#687)
  4. Numerous minor bugfixes to polygon offsetting (AngusJohnson#703, AngusJohnson#715, AngusJohnson#724)
  5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (AngusJohnson#720)
  6. Significantly improved documentation.
1. Fixed a significant offsetting bug introduced in previous update (AngusJohnson#733)
2. Fixed a C++ compile error when 32bit compiling (AngusJohnson#727)
3. Minor tweak to CMakeLists.txt (C++) (AngusJohnson#728)
4. Will now offset 'flat' polygons (Disc.AngusJohnson#725)
5. Reminder: recent change in open path offsetting behaviour (AngusJohnson#707)
6. Reminder: recent changes to clipper.export.h data structures.
@Egliss Egliss requested a review from aoki-makoto November 30, 2023 01:58
Copy link

@aoki-makoto aoki-makoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libraryとして新規提供されているのはHashCode.csのみ


LGTMです!

@Egliss Egliss merged commit ec1226e into drecom/develop Nov 30, 2023
1 check passed
@Egliss Egliss deleted the feature/merge-1.3.0 branch November 30, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.