Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variable to allow customer specifying event details for EB … #56

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

IgorEulalio
Copy link
Contributor

…rule for single and org deployment

Testing your PR

You can pinpoint the pr changes as terraform module source with following format

source                    = "github.com/draios/terraform-aws-secure-for-cloud//examples/organizational-ecs?ref=<BRANCH_NAME>"

General recommendations

Check contribution guidelines at https://github.com/draios/terraform-aws-secure-for-cloud/blob/master/CONTRIBUTE.md#contribution-checklist

For a cleaner PR make sure you follow these recommendations:

  • Review modified files and delete small changes that were not intended and maybe slip the commit.
  • Use Pull Request Drafts for visibility on Work-In-Progress branches and use them on daily mob/pairing for team review
  • Unless an external revision is desired, in order to validate or gather some feedback, you are free to merge as long as validation checks are green-lighted

Checklist

  • [ x ] If test/fixtures/*/main.tf files are modified, update:
    • [ x ] the snippets in the README.md file under root folder.
    • [ x ] the snippets in the README.md file for the corresponding example.
  • [ x ] If examples folder are modified, update:
    • [ x ] README.md file with pertinent changes.
    • [ x ] test/fixtures/*/main.tf in case the snippet needs modifications.
  • [ x ] If any architectural change has been made, update the diagrams.

@IgorEulalio IgorEulalio requested a review from a team as a code owner March 1, 2024 16:02
@cgeers
Copy link
Contributor

cgeers commented Mar 5, 2024

to ease future changes, feel free to add your github team to the CODEOWNERS for the path of this module.

@IgorEulalio IgorEulalio merged commit 08179d2 into main Mar 5, 2024
5 checks passed
@IgorEulalio IgorEulalio deleted the feature/make-eb-rule-event-pattern-customizable branch March 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants