Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CANNOT connet to Redis with special password #2893 #2894

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: CANNOT connet to Redis with special password #2893 #2894

merged 1 commit into from
Nov 22, 2023

Conversation

karlhjm
Copy link
Contributor

@karlhjm karlhjm commented Nov 21, 2023

Description

Related Issue

CANNOT connet to Redis with special password #2893

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@karlhjm karlhjm requested a review from a team as a code owner November 21, 2023 12:38
gaius-qi
gaius-qi approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 21c19a9 into dragonflyoss:main Nov 22, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@garenwen garenwen Awaiting requested review from garenwen garenwen is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@anjia0532 anjia0532 Awaiting requested review from anjia0532 anjia0532 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@fcgxz2003 fcgxz2003 Awaiting requested review from fcgxz2003 fcgxz2003 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlhjm @gaius-qi