Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client/daemon): cleanup, and add noTLSConfig #2783

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sashamelentyev
Copy link
Contributor

Description

Cleanup, and add noTLSConfig instead nil for better readable

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@sashamelentyev sashamelentyev requested a review from a team as a code owner October 9, 2023 17:03
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2783 (c795d03) into main (2b4e378) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   52.40%   52.34%   -0.06%     
==========================================
  Files         157      157              
  Lines       21248    21248              
==========================================
- Hits        11135    11123      -12     
- Misses       9464     9479      +15     
+ Partials      649      646       -3     
Flag Coverage Δ
e2etests ?
unittests 52.34% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit eeea18b into dragonflyoss:main Oct 10, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants