Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize dynconfig error log #2771

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Oct 8, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner October 8, 2023 06:24
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #2771 (3f7368d) into main (c9c7100) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2771      +/-   ##
==========================================
+ Coverage   52.35%   52.37%   +0.01%     
==========================================
  Files         157      157              
  Lines       21237    21237              
==========================================
+ Hits        11119    11122       +3     
+ Misses       9470     9469       -1     
+ Partials      648      646       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 52.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/config/dynconfig_manager.go 62.01% <100.00%> (ø)

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 237eb9e into main Oct 8, 2023
13 of 21 checks passed
@gaius-qi gaius-qi deleted the chore/optimize-dynconfig-error-log branch October 8, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants