This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 773
fix: unreachable supernode ip in p2p-network #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 58.89% 58.73% -0.16%
==========================================
Files 56 36 -20
Lines 2788 1854 -934
==========================================
- Hits 1642 1089 -553
+ Misses 1068 723 -345
+ Partials 78 42 -36
Continue to review full report at Codecov.
|
lowzj
force-pushed
the
supernode-localIP
branch
from
December 25, 2018 02:56
f382f0c
to
bbad84b
Compare
lowzj
force-pushed
the
supernode-localIP
branch
from
January 31, 2019 18:47
bbad84b
to
bb09fd6
Compare
lowzj
force-pushed
the
supernode-localIP
branch
from
January 31, 2019 18:55
343d417
to
b4fa21b
Compare
lowzj
force-pushed
the
supernode-localIP
branch
2 times, most recently
from
February 2, 2019 08:26
9ac9950
to
4ea9917
Compare
lowzj
force-pushed
the
supernode-localIP
branch
2 times, most recently
from
March 1, 2019 06:25
5b3f004
to
0d29e3f
Compare
see issue: dragonflyoss#252 Signed-off-by: lowzj <[email protected]>
LGTM. |
starnop
added a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
fix: unreachable supernode ip in p2p-network
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
fix: unreachable supernode ip in p2p-network
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
* feat: rename codeql-analysis.yml to codeql-analysis.yaml Signed-off-by: Gaius <[email protected]> * feat: release workflows Signed-off-by: Gaius <[email protected]> * feat: rename yaml to yml Signed-off-by: Gaius <[email protected]> * chore: optimize workflow Signed-off-by: Gaius <[email protected]> * chore: add license check workflow Signed-off-by: Gaius <[email protected]> * chore: remove licenses check Signed-off-by: Gaius <[email protected]> * chore: workflows golang version Signed-off-by: Gaius <[email protected]> * chore: language go Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lowzj [email protected]
Ⅰ. Describe what this PR did
Make it possible for users to set the supernode's ip that we advertiese to other peers in the p2p-network, the property is:
advertieseIp
By default, the first non-loop address of the host is advertied.
Ⅱ. Does this pull request fix one issue?
fixes: #252