Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

fix: unreachable supernode ip in p2p-network #277

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

lowzj
Copy link
Member

@lowzj lowzj commented Dec 24, 2018

Signed-off-by: lowzj [email protected]

Ⅰ. Describe what this PR did

Make it possible for users to set the supernode's ip that we advertiese to other peers in the p2p-network, the property is: advertieseIp

java -Dsupernode.advertieseIp=10.1.1.1 -jar supernode.jar

By default, the first non-loop address of the host is advertied.

Ⅱ. Does this pull request fix one issue?

fixes: #252

@pouchrobot pouchrobot added areas/network kind/bug This is bug report for project size/M labels Dec 24, 2018
@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #277 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   58.89%   58.73%   -0.16%     
==========================================
  Files          56       36      -20     
  Lines        2788     1854     -934     
==========================================
- Hits         1642     1089     -553     
+ Misses       1068      723     -345     
+ Partials       78       42      -36
Impacted Files Coverage Δ
dfget/core/uploader/uploader.go 25% <0%> (-69.18%) ⬇️
...core/downloader/back_downloader/back_downloader.go 0% <0%> (-59.19%) ⬇️
dfget/core/uploader/uploader_util.go 67.03% <0%> (-30.03%) ⬇️
dfget/core/downloader/downloader.go 72.09% <0%> (-27.91%) ⬇️
dfget/errors/errors.go 37.03% <0%> (-6.45%) ⬇️
cmd/dfget/app/root.go 61.87% <0%> (-5.51%) ⬇️
cmd/dfget/app/server.go 55.55% <0%> (-4.45%) ⬇️
dfget/core/api/uploader_api.go 0% <0%> (ø) ⬆️
dfdaemon/util/urlutil.go 100% <0%> (ø) ⬆️
dfget/core/helper/test_helper.go 0% <0%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbce79b...432bd86. Read the comment docs.

@lowzj lowzj force-pushed the supernode-localIP branch from f382f0c to bbad84b Compare December 25, 2018 02:56
@lowzj lowzj closed this Jan 31, 2019
@lowzj lowzj force-pushed the supernode-localIP branch from bbad84b to bb09fd6 Compare January 31, 2019 18:47
@pouchrobot pouchrobot added size/XS and removed size/M labels Jan 31, 2019
@lowzj lowzj reopened this Jan 31, 2019
@lowzj lowzj force-pushed the supernode-localIP branch from 343d417 to b4fa21b Compare January 31, 2019 18:55
@pouchrobot pouchrobot added size/M and removed size/XS labels Jan 31, 2019
@lowzj lowzj requested a review from chenchaobing February 1, 2019 07:55
@lowzj lowzj force-pushed the supernode-localIP branch 2 times, most recently from 9ac9950 to 4ea9917 Compare February 2, 2019 08:26
@lowzj lowzj force-pushed the supernode-localIP branch 2 times, most recently from 5b3f004 to 0d29e3f Compare March 1, 2019 06:25
@lowzj lowzj force-pushed the supernode-localIP branch from 0d29e3f to 432bd86 Compare March 1, 2019 06:27
@starnop
Copy link
Contributor

starnop commented Mar 1, 2019

LGTM.

@starnop starnop merged commit c8b4264 into dragonflyoss:master Mar 1, 2019
@lowzj lowzj deleted the supernode-localIP branch March 1, 2019 06:40
starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
fix: unreachable supernode ip in p2p-network
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
fix: unreachable supernode ip in p2p-network
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
* feat: rename codeql-analysis.yml to codeql-analysis.yaml

Signed-off-by: Gaius <[email protected]>

* feat: release workflows

Signed-off-by: Gaius <[email protected]>

* feat: rename yaml to yml

Signed-off-by: Gaius <[email protected]>

* chore: optimize workflow

Signed-off-by: Gaius <[email protected]>

* chore: add license check workflow

Signed-off-by: Gaius <[email protected]>

* chore: remove licenses check

Signed-off-by: Gaius <[email protected]>

* chore: workflows golang version

Signed-off-by: Gaius <[email protected]>

* chore: language go

Signed-off-by: Gaius <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] dfget fails to pull images
4 participants