Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dfdaemon.yaml in rpm and deb #885

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 5, 2024

Description

This pull request involves significant changes to the dfdaemon configuration and the dragonfly-client package setup. The most important changes include the removal of the dfdaemon.yaml configuration file and related references, as well as minor adjustments to the logging setup in the dfdaemon.rs file.

Configuration and setup changes:

  • Removed the entire dfdaemon.yaml configuration file from the ci directory.
  • Removed references to dfdaemon.yaml from the assets section in the Cargo.toml files for various target platforms in the dragonfly-client package. [1] [2] [3] [4] [5] [6] [7] [8]

Code adjustments:

  • Removed the info logging statement from the impl Config block in the dfdaemon.rs file.
  • Updated the use statement to remove the info import from the tracing crate in the dfdaemon.rs file.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v1.0.0 milestone Dec 5, 2024
@gaius-qi gaius-qi self-assigned this Dec 5, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner December 5, 2024 09:33
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 33.82%. Comparing base (31edec8) to head (410d5e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/bin/dfdaemon/main.rs 0.00% 26 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   33.91%   33.82%   -0.10%     
==========================================
  Files          59       59              
  Lines        8996     9021      +25     
==========================================
  Hits         3051     3051              
- Misses       5945     5970      +25     
Files with missing lines Coverage Δ
dragonfly-client-config/src/dfdaemon.rs 47.73% <ø> (ø)
dragonfly-client/src/bin/dfdaemon/main.rs 0.00% <0.00%> (ø)

@gaius-qi gaius-qi merged commit 6e25a2f into main Dec 5, 2024
6 checks passed
@gaius-qi gaius-qi deleted the feature/rpm-config branch December 5, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants