Skip to content

Commit

Permalink
feat: remove optional in download message (#213)
Browse files Browse the repository at this point in the history
Signed-off-by: Gaius <[email protected]>
  • Loading branch information
gaius-qi authored Nov 16, 2023
1 parent 6d86592 commit ac4597d
Show file tree
Hide file tree
Showing 7 changed files with 108 additions and 113 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "dragonfly-api"
version = "2.0.50"
version = "2.0.51"
authors = ["Gaius <[email protected]>"]
edition = "2021"
license = "Apache-2.0"
Expand Down
177 changes: 88 additions & 89 deletions pkg/apis/common/v2/common.pb.go

Large diffs are not rendered by default.

34 changes: 15 additions & 19 deletions pkg/apis/common/v2/common.pb.validate.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/common/v2/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ message Download {
// Task piece length.
int32 piece_length = 10 [(validate.rules).int32.gte = 1];
// File path to be exported.
optional string output_path = 11 [(validate.rules).string = {min_len: 1, ignore_empty: true}];
string output_path = 11 [(validate.rules).string = {min_len: 1, ignore_empty: true}];
// Download timeout.
optional google.protobuf.Duration timeout = 12 [(validate.rules).duration.required = true];
// Download rate limit in bytes per second.
Expand Down
2 changes: 1 addition & 1 deletion proto/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ message Download {
// Task piece length.
int32 piece_length = 10;
// File path to be exported.
optional string output_path = 11;
string output_path = 11;
// Download timeout.
optional google.protobuf.Duration timeout = 12;
// Download rate limit in bytes per second.
Expand Down
4 changes: 2 additions & 2 deletions src/common.v2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,8 @@ pub struct Download {
#[prost(int32, tag = "10")]
pub piece_length: i32,
/// File path to be exported.
#[prost(string, optional, tag = "11")]
pub output_path: ::core::option::Option<::prost::alloc::string::String>,
#[prost(string, tag = "11")]
pub output_path: ::prost::alloc::string::String,
/// Download timeout.
#[prost(message, optional, tag = "12")]
pub timeout: ::core::option::Option<::prost_wkt_types::Duration>,
Expand Down
Binary file modified src/descriptor.bin
Binary file not shown.

0 comments on commit ac4597d

Please sign in to comment.