fix: cluster_mgr script #4210
Merged
fix: cluster_mgr script #4210
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
previously approved these changes
Nov 27, 2024
BorysTheDev
force-pushed
the
fix_cluster_mgr_script_and_test
branch
from
5f6a49c
to
242c847
Compare
chakaz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: unclosed connection prevents correct cluster node close for cluster_mgr_test.py
fix: I've found a couple of places where we didn't close clients correctly, and @chakaz told me that we should use 127.0.0.1 instead of localhost