Add a mechanism to escape '+' fragments #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, it was not possible to start a line with `+` at all, which is particularly problematic when you have a diff in literal blocks. Possibly a better long-term fix for this problem would be to disable all pre-processing between triple-backticks, but the ability to escape `+` at the beginning of a line seems useful in itself and is much easier to implement.
mrmanc
reviewed
Sep 2, 2022
| @@ -62,13 +62,22 @@ | |||
| | replace:'<backgroundimageopacity>','<!-- .slide: data-background-opacity="' | |||
| | replace:'</backgroundimageopacity>','" -->' | |||
| %}{% | |||
| assign first_char = line | strip | |||
There was a problem hiding this comment.
Was it important to remove the strip filter? I think this is there to make sure we still detect indented fragments. Looking at your change locally it looks like the indented fragment now renders with it’s parent rather than as a separate step.
|
I’ve found that this also impacts mermaid diagrams which have indented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, it was not possible to start a line with
+at all, which is particularly problematic when you have a diff in literal blocks.Possibly a better long-term fix for this problem would be to disable all pre-processing between triple-backticks, but the ability to escape
+at the beginning of a line seems useful in itself and is much easier to implement.