Change language to rust to let pre-commit bootstrap rust #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an empty cargo.toml to fool the build system
Terseus
added a commit
to Terseus/yet-another-md5
that referenced
this pull request
Nov 4, 2023
Unfortunately the hooks in pre-commit-rust doesn't work on pre-commit-ci because it have language as "system" instead of "rust". See doublify/pre-commit-rust#28 Although we may get away of this using "repo: local" I don't think is worth the effort.
|
this would be really nice |
|
I prefer this as an option as exact version of rust is important. E.g. some projects use nightly starting from specific version and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this would fail on pre-commit.ci since it doesn't declare itself that it requires cargo.
See: before, after.
cargo fmtwill work now.cargo clippystill won't work since it requires access to the internet.