fix: Handle Salamandra and OpenCoder tokenizers #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torymur
force-pushed
the
fix/parsing-token-vocabularies-edge-cases
branch
from
ca83995
to
cb52a64
Compare
torymur
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salamandra and OpenCoder tokenizers use ".�" and "�s" in their vocabularies, respectively, which causes errors with Outlines.
This is similar to this previous PR, which featured other variations of the � symbol, and was fixed then by extending the
re_replacement_seqregex to accommodate these variations. This PR does exactly the same as before, adding the options of having a "." before �, as well as an "s" after.