Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wheel Build for release_pypi.yaml #57

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix Wheel Build for release_pypi.yaml #57

merged 1 commit into from
Oct 10, 2024

Conversation

lapp0
Copy link
Contributor

@lapp0 lapp0 commented Oct 9, 2024 •
edited
Loading

Fixes

  • linux aarch64 builds successful
  • windows builds enabled and successful
  • macos builds successful

Other changes

  • add python3.13 builds

Runs

@lapp0 lapp0 changed the title Verify Wheel Build in PR Fix Wheel Build for release_pypi.yaml Oct 9, 2024
@rlouf
Copy link
Member

rlouf commented Oct 9, 2024

Can you run the build on windows now that I've removed the dependency on pyarrow?

@lapp0 lapp0 force-pushed the wheel-PR-CI branch 5 times, most recently from 854a69d to 46a9c07 Compare October 10, 2024 02:37
@lapp0
Copy link
Contributor Author

lapp0 commented Oct 10, 2024 •
edited
Loading

@rlouf rebased with main. wheel and sdist build succeed, but

.github/workflows/pr_test_wheel.yaml / Build wheels on macos-11 (pull_request) is stuck in queue, presumably because there are no macos runners. Thoughts?

macos-11 is no longer supported by github actions. Fixed via macos-latest and

- run: rustup target add x86_64-apple-darwin

@lapp0 lapp0 marked this pull request as ready for review October 10, 2024 05:12
@lapp0 lapp0 force-pushed the wheel-PR-CI branch 4 times, most recently from 57c6676 to 14ea579 Compare October 10, 2024 06:11
@rlouf rlouf merged commit 4f3e075 into main Oct 10, 2024
8 checks passed
@rlouf rlouf deleted the wheel-PR-CI branch October 10, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lapp0 @rlouf