Skip to content

Commit

Permalink
VMR: move DevVersions jobs to a separate stage (#45226)
Browse files Browse the repository at this point in the history
Don't run the validation jobs during the official build.

Fixes dotnet/source-build#4769
  • Loading branch information
akoeplinger authored Dec 2, 2024
1 parent 96c06f8 commit 6bbbb01
Showing 1 changed file with 17 additions and 6 deletions.
23 changes: 17 additions & 6 deletions eng/pipelines/templates/stages/vmr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,10 @@ stages:
# reuseBuildArtifactsFrom:
# - ${{ format('{0}_Mono_Offline_MsftSdk_x64', variables.centOSStreamName) }}

#### VERTICAL BUILD ####
- ${{ if not(parameters.isSourceOnlyBuild) }}:
- stage: VMR_Vertical_Build
displayName: VMR Vertical Build
#### VERTICAL BUILD (Validation) ####
- ${{ if and(not(parameters.isSourceOnlyBuild), or(eq(variables['Build.Reason'], 'PullRequest'), ne(variables['System.TeamProject'], 'internal'))) }}:
- stage: VMR_Vertical_Build_Validation
displayName: VMR Vertical Build Validation
dependsOn: []
variables:
- template: ../variables/vmr-build.yml
Expand All @@ -368,7 +368,7 @@ stages:
container: ${{ variables.ubuntuContainer }}
targetOS: linux
targetArchitecture: x64
useDevVersions: true # Use dev versions for CI validation of the experience. If we decide to ship assets from this leg, then we should remove this option.
useDevVersions: true # Use dev versions for CI validation of the experience.
runTests: false # Temporarily do not run tests. The nuget comparison fails for some non-obvious reason and needs further investigation. Mostly, I'm not sure why it ever passed. https://github.com/dotnet/sdk/issues/42920

- template: ../jobs/vmr-build.yml
Expand All @@ -391,9 +391,20 @@ stages:
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: x64
useDevVersions: true # Use dev versions for CI validation of the experience. If we decide to ship assets from this leg, then we should remove this option.
useDevVersions: true # Use dev versions for CI validation of the experience.
runTests: false # Temporarily do not run tests. The nuget comparison fails for some non-obvious reason and needs further investigation. Mostly, I'm not sure why it ever passed. https://github.com/dotnet/sdk/issues/42920

#### VERTICAL BUILD (Official) ####
- ${{ if not(parameters.isSourceOnlyBuild) }}:
- stage: VMR_Vertical_Build
displayName: VMR Vertical Build
dependsOn: []
variables:
- template: ../variables/vmr-build.yml
parameters:
vmrBranch: ${{ parameters.vmrBranch }}
jobs:

- template: ../jobs/vmr-build.yml
parameters:
buildName: Windows
Expand Down

0 comments on commit 6bbbb01

Please sign in to comment.