Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime async format to use methodimpl #76105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update runtime async format to use methodimpl #76105

wants to merge 1 commit into from
+14 −7

Conversation

333fred
Copy link
Member

@333fred 333fred commented Nov 26, 2024

This will save us some space in metadata. Runtime-side doc PR is forthcoming.

@333fred
Update runtime async format to use methodimpl
d960b54 
This will save us some space in metadata. Runtime-side doc PR is forthcoming.
@333fred 333fred requested a review from a team as a code owner November 26, 2024 20:56
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 26, 2024
@jcouv jcouv self-assigned this Nov 26, 2024
jcouv
jcouv approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1). nit: Consider clarify the "disallowing attribute in user code" part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Documentation New Feature - Runtime Async untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@333fred @jcouv