WIP: Update to use AzureCliCredential instead of key #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This can't be tested right now due to an infrastructure issue
captainsafia
reviewed
Oct 8, 2024
| BlobContainerClient container; | ||
| try | ||
| { | ||
| container = new BlobContainerClient(azureStorageConnectionString, blobContainerName: "areamodels"); | ||
| container = new BlobContainerClient(new Uri("https://dotnetissuelabelerdata.blob.core.windows.net/areamodels"), new AzureCliCredential()); |
There was a problem hiding this comment.
We can use new DefaultAzureCredential() here instead. This way it will try to resolve Azure credentials from a number of sources (including CLI) which might work better for people who are already authenticated into Azure in Visual Studio or VS Code.
RussKie
reviewed
Dec 18, 2024
| BlobContainerClient container; | ||
| try | ||
| { | ||
| container = new BlobContainerClient(azureStorageConnectionString, blobContainerName: "areamodels"); | ||
| container = new BlobContainerClient(new Uri("https://dotnetissuelabelerdata.blob.core.windows.net/areamodels"), new AzureCliCredential()); |
There was a problem hiding this comment.
It's probably not a good idea to hardcode the storage account name. Instead, it should be configurable.
We'll need to make the same (or similar) change in other places in the solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This can't be tested right now due to an infrastructure issue (that we talked about in Teams)
Just putting it here in case that issue gets resolved, and then we have code/docs to work from. Happy to test it out when possible.