Add API allowing to disable retries for a given list of HTTP methods #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds APIs allowing to disable automatic retries for a given list of HTTP methods
iliar-turdushev
commented
Nov 13, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Polly/HttpRetryStrategyOptionsExtensions.cs
Show resolved
Hide resolved
iliar-turdushev
requested review from
SteveSandersonMS,
martintmk and
RussKie
iliar-turdushev
commented
Nov 13, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Polly/HttpRetryStrategyOptionsExtensions.cs
Show resolved
Hide resolved
|
@martintmk @SteveSandersonMS Please, review this PR and the PR with documentation dotnet/docs#43630. Thank you. |
dariusclay
approved these changes
Nov 19, 2024
mobratil
approved these changes
Nov 19, 2024
martintmk
reviewed
Nov 20, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Polly/HttpRetryStrategyOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
martintmk
approved these changes
Nov 20, 2024
Adds a check ensuring options.ShouldHandle is not null
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces an API that allows to disable automatic retries for
Here is the approved API #5248 (comment).
The documentation will be added in a separate PR dotnet/docs#43630.
Closes #5248.