Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Uniquify all variables used in SQL Server migration scripts #35228

Open
wants to merge 1 commit into
base: release/9.0-staging
Choose a base branch
from

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Nov 27, 2024

Port of #35177
Fixes #35132

Description

We made a change in EF 9.0 to execute all migration operations in a single transaction/batch. However, we generate SQL variables in the script for some operations. And now that they are in the same batch they started conflicting.
The fix is to uniquify the variable names.

Customer impact

The SQL Server migration script is invalid in the above scenario. The workaround is to fix the script manually before executing it.

How found

Customer reported on 9.

Regression

Yes, from 8.

Testing

Existing tests changed to cover this.

Risk

Low.

@maumar
Copy link
Contributor

maumar commented Nov 27, 2024

quicks are missing - looks good otherwise

@AndriySvyryd
Copy link
Member Author

No quirks because this is tooling code and quirks are hard to turn on when running it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants