Support multiple VMRs in PCS #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrBackflower.cs
Outdated
Show resolved
Hide resolved
oleksandr-didyk
previously approved these changes
Nov 25, 2024
src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrForwardFlower.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleksandr Didyk <[email protected]>
dkurepa
reviewed
Nov 26, 2024
src/Microsoft.DotNet.Darc/Darc/Options/VirtualMonoRepo/CodeFlowCommandLineOptions.cs
Show resolved
Hide resolved
dkurepa
reviewed
Nov 26, 2024
src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrRegistrations.cs
Outdated
Show resolved
Hide resolved
dkurepa
reviewed
Nov 26, 2024
dkurepa
previously approved these changes
Nov 26, 2024
dkurepa
previously approved these changes
Nov 26, 2024
dkurepa
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports using a different VMRs during background jobs so that we can target
maestro-auth-testas well as the main VMR.Resolves #3942
Additionally removes support for flowing a specific SHA, we will be flowing builds only for now. If
darcneeds to flow SHA without builds (for some localupdate-dependenciescommand that will be added later), it will be added later. Right now it's expensive to maintain both ways if we're not using one of them.