Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the case of a superstate having a trigger that moves the state to … #544

Merged

Conversation

hooligan495
Copy link

@hooligan495 hooligan495 commented Oct 5, 2023

…a substate, if the machine is already in that substate then the entry action shouldn't trigger again. this pr is for Issue #543

…a substate, if the machine is already in that substate then the entry action shouldn't trigger again
@hooligan495
Copy link
Author

If there is a better approach let's discuss. After going through the stateless source code tho, this approach seemed the most stable to me. but this is my first foray in to stateless.

@HenningNT
Copy link
Contributor

HenningNT commented Oct 31, 2023

Look very good to me!
Thank you for your contribution!

@crozone
Copy link
Collaborator

crozone commented Nov 1, 2023

Looks good to me, if I understand the case correctly the intentional re-entry case will be handled by InternalTriggerBehaviour, so this just stops the superstate edgecase where the superstate re-enters itself in the TransitioningTriggerBehaviour case.

@mclift mclift merged commit 99e49a8 into dotnet-state-machine:dev Nov 8, 2023
1 check passed
mclift added a commit to mclift/stateless that referenced this pull request Apr 22, 2024
mclift added a commit to mclift/stateless that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants