Fixing traceback bugs #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsole instead to make it less disruptive)
…iding the problem rather than actually fixing it, but the AttributeError caused by the missing popup_states dictionary may be due to it not being set yet at startup maybe?
|
Hi, thanks for the PR! I haven't had time to work on Dopey for several months, but I'll see if I can review your patch in the near future. |
|
bump. |
|
Closing this to clear up my PR queue since it appears this fork is dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some of the immediate tracebacks that popped up as soon as the program was started. It also cures a few tracebacks that makes the program usable without having the traceback dialogue appear as soon as any button is pressed or the up/down keyboard shortcuts are used. Since I don't know pygtk+, this took longer than it could have and involved some retries.
Also made some bug reporting print to terminal rather than pop up (yet another) traceback. With these fixes I find dopey works stably enough to animate with. :) I also took a stab at merging in the latest MyPaint master but gave up on this for now - I don't know enough pygtk nor MyPaint internals to diagnose what moved around.
Resolves #16.