Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _safe_split function #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyblue9
Copy link
Contributor

@cyblue9 cyblue9 commented Aug 10, 2018

Fixed return value of _safe_split function.

_safe_split function return value is list type, but If an exception occurs, str type is returned.
At that time, get_completions() -> completing_subcommand_option() -> return [](in https://github.com/donnemartin/haxor-news/blob/master/haxor_news/completer.py 184 line).
This is the same as to return [] in completer.py 172 line.
So, If an exception occurs, [] is returned in _safe_split, the behavior does not change!

Please confirm!

@codecov-io
Copy link

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          31       31           
  Lines        1469     1469           
=======================================
  Hits         1374     1374           
  Misses         95       95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants