PLAT-5147 retrieving findings by a search query #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to PLAT-5147_Dome9_TF_Provider_for_retrieving_findings_by_a_search_query
…to PLAT-5147_Dome9_TF_Provider_for_retrieving_findings_by_a_search_query
yogevktuvim
approved these changes
Aug 24, 2022
dolevh-d9
requested changes
Aug 25, 2022
| @@ -0,0 +1,14 @@ | |||
| package continuous_compliance_finding | |||
There was a problem hiding this comment.
Please delete this file. It's taken automatically from the SDK
| @@ -0,0 +1,139 @@ | |||
| package continuous_compliance_finding | |||
There was a problem hiding this comment.
Please delete this file. It's taken automatically from the SDK
| @@ -9,6 +9,7 @@ const ( | |||
| CloudAccountKubernetes = "dome9_cloudaccount_kubernetes" | |||
There was a problem hiding this comment.
After updating the SDK please update the go.mod file to use the newest SDK version
dolevh-d9
reviewed
Aug 25, 2022
| "github.com/terraform-providers/terraform-provider-dome9/dome9/common/testing/method" | ||
| ) | ||
|
|
||
| func TestAccDataSourceFindingSearchBasic(t *testing.T) { |
There was a problem hiding this comment.
I would try to create in Terraform the new asset you created to check that everything really works as required. Because it is possible that the test here misses cases.
…_findings_by_a_search_query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.