Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new config variables previously not propagated in the code #524

Merged
merged 1 commit into from
May 22, 2024

Conversation

ryuksan
Copy link
Contributor

@ryuksan ryuksan commented May 14, 2024

#523

The new config variables were not correctly propagated in the code (8.11.0).

always_use_local_files - Disables the download of the reverse DNS map
local_reverse_dns_map_path - Overrides the default local file path to use for the reverse DNS map
reverse_dns_map_url - Overrides the default download URL for the reverse DNS map

i.e. If you set the config variable always_use_local_files = True in the parsedmarc.ini, it will always be False while parsing the reports using a mbox or mailbox

There are 2 specific calls to parse_report_email that need the new arguments to be passed (in __init__.py)
Without passing them, the default value (False or None) will always be applied.
After that, this code should be propagated back in the __init__.py and cli.py files

@ryuksan ryuksan changed the title Fix new config variables previously not propagated in the code #523 Fix new config variables previously not propagated in the code May 14, 2024
@seanthegeek seanthegeek merged commit f8ee9bd into domainaware:master May 22, 2024
1 check failed
seanthegeek added a commit that referenced this pull request May 22, 2024
- Fix for deadlock with large report (#508)
- Build: move to kafka-python-ng (#510)
- Fix new config variables previously not propagated in the code (#524)
- Fixes for kafka integration (#522)
- Fix if base_domain is None before get_service_from_reverse_dns_base_domain (#514)
- Update base_reverse_dns_map.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants