removing unused parallel arguments #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 11 11
Lines 1530 1530
=======================================
Hits 905 905
Misses 625 625 ☔ View full report in Codecov by Sentry. |
|
Please resolve the conflicts and I'll merge this. Thanks! |
|
@seanthegeek thank you, the merge conflict is resolved. I have rebased the commit on the top of the new master for a cleaner history. |
seanthegeek
added a commit
that referenced
this pull request
Mar 25, 2024
- Add source name and type information based on static mapping of the reverse DNS base domain - See [this documentation](https://github.com/domainaware/parsedmarc/tree/master/parsedmarc/resources/maps) for more information, and to learn how to help! - Replace `multiprocessing.Pool` with `Pipe` + `Process` (PR #491 closes issue #489) - Remove unused parallel arguments (PR #492 closes issue #490)
seanthegeek
added a commit
that referenced
this pull request
Mar 25, 2024
- Fix broken cache (PR #494) - Add source name and type information based on static mapping of the reverse DNS base domain - See [this documentation](https://github.com/domainaware/parsedmarc/tree/master/parsedmarc/resources/maps) for more information, and to learn how to help! - Replace `multiprocessing.Pool` with `Pipe` + `Process` (PR #491 closes issue #489) - Remove unused parallel arguments (PR #492 closes issue #490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #490
Will probably cause a merge conflict with #491