Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor presets #13

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

bal7hazar
Copy link
Collaborator

  • Rename into token
  • Add token into workspace

Workload ~ 1h

- Rename into token
- Add token into workspace
Copy link
Collaborator

@notV4l notV4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be convenient to add extra interfaces ERCXXXABI like OZ :
https://github.com/OpenZeppelin/cairo-contracts/blob/cd0ce89cffda855768b4ed2c4a9b5aaa2479b0fa/src/token/erc20/interface.cairo#L61

lets remove tests/test_erc721 & tests/test_erc1155 since its not used

@bal7hazar
Copy link
Collaborator Author

bal7hazar commented Nov 28, 2023

it could be convenient to add extra interfaces ERCXXXABI like OZ : https://github.com/OpenZeppelin/cairo-contracts/blob/cd0ce89cffda855768b4ed2c4a9b5aaa2479b0fa/src/token/erc20/interface.cairo#L61

lets remove tests/test_erc721 & tests/test_erc1155 since its not used

Done

@tarrencev tarrencev merged commit 5fd9efa into dojoengine:main Nov 30, 2023
5 checks passed
@bal7hazar bal7hazar deleted the feat/migrate-ercs branch December 1, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants