-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #6
base: main
Are you sure you want to change the base?
Conversation
Windows ID3D11DeviceContext likes rewriting its own vtable pointers, so we can't hook it that way
Looks like the original fix broke dxvk (and therefore proton) support, I switched the hook method of ID3D11Device over as well and that seems to have fixed that, it now runs on steam deck as well as windows. |
I've considered doing this before, but the problem is that wrapping the device will break Might be more useful to fix DXVK to not call any (potentially hooked) GetImmediateContext method internally. |
For some reason, LOAD_LIBRARY_SEARCH_APPLICATION_DIR won't find a dxvk dll next to the main exe on Windows
Ahh yeah, I missed that one I've removed that commit for now |
Hi, @TellowKrinkle Sorry to post here. But Atelier games after Ryza 2 have a tendency to freeze during loading transitions on some machines, especially on linux through proton. Is there any solution to this that you can find? Thanks! |
Does "after Ryza 2" include Ryza 2? If so, I've played Ryza 2 (with sync fix) a decent amount from a steam deck and had no freezes, so I'm not sure how much I can help. Otherwise, I have yet to play a post-Ryza 2 game, but when I do eventually play one I'll make sure to include some steam deck time to see if I hit anything. |
Hi. Ryza 2 has freezes but they are exceedingly unsual. They are unfortunately fairly common in Sophie 2 and Ryza 3El 27 ago. 2023 23:02, TellowKrinkle ***@***.***> escribió:
Does "after Ryza 2" include Ryza 2? If so, I've played Ryza 2 (with sync fix) a decent amount from a steam deck and had no freezes, so I'm not sure how much I can help. Otherwise, I have yet to play a post-Ryza 2 game, but when I do eventually play one I'll make sure to include some steam deck time to see if I hit anything.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
You can see it in the proton github threads for ryza 3 and sophie 2. Basically area transitions may just hang forcing a gamequitEl 27 ago. 2023 23:15, Federico Frasisti ***@***.***> escribió:Hi. Ryza 2 has freezes but they are exceedingly unsual. They are unfortunately fairly common in Sophie 2 and Ryza 3El 27 ago. 2023 23:02, TellowKrinkle ***@***.***> escribió:
Does "after Ryza 2" include Ryza 2? If so, I've played Ryza 2 (with sync fix) a decent amount from a steam deck and had no freezes, so I'm not sure how much I can help. Otherwise, I have yet to play a post-Ryza 2 game, but when I do eventually play one I'll make sure to include some steam deck time to see if I hit anything.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
You can see people discuss the freezing here for instance ValveSoftware/Proton#5841 |
ValveSoftware/Proton#4569 (comment) here is a ryza 2 issue and log |
If you have any more things to add, please mention me on the relevant issues instead of posting more here |
Note: Current main just failed to change anything (rather than crashing) when built with VS, so you might want to verify that the mingw builds work on Windows