Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to control to otel resources #5

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Conversation

hobord
Copy link
Collaborator

@hobord hobord commented Oct 8, 2024

No description provided.

@hobord hobord requested review from eyalzek and lauraseidler October 8, 2024 13:43
cluster/variables.tf Outdated Show resolved Hide resolved
@eyalzek
Copy link
Contributor

eyalzek commented Oct 8, 2024

Did someone run into issues, or why is this change suggested?
Reading through [1] it sounds like this should be done on top of configuring GOMEMLIMIT and probably memory requests/limits since this is running on k8s.
But in this case the resource requirements are optional and the memory limiter has defaults set, so I'm slightly confused.

[1] https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/README.md#best-practices

@hobord
Copy link
Collaborator Author

hobord commented Oct 11, 2024

I added the option to set the GOMEMLIMIT env variable too...

@hobord hobord requested a review from eyalzek October 11, 2024 10:11
Copy link
Contributor

@eyalzek eyalzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update readme [1] to reflect new variables. Might also be useful to add a description rather than inline comments

[1] https://github.com/doitintl/terraform-eks-lens/blob/main/cluster/README.md

@hobord hobord requested a review from eyalzek October 11, 2024 12:42
@hobord hobord changed the title add otions to control to otel resources add options to control to otel resources Oct 11, 2024
Copy link

apiiro bot commented Oct 14, 2024

WORKFLOW-9 · Pipeline misconfiguration added

Other

  • ⚠ Code finding Ensure top-level permissions are not set to write-all (terraform-fmt.yaml)
    • ⚠ New misconfiguration: Ensure top-level permissions are not set to write-all. Detected in .github/workflows/terraform-fmt.yaml

Repository: terraform-eks-lens

View in Apiiro

@hobord hobord merged commit c551ee2 into main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants