fix signal log message; release on tag only

doitintl · Mar 27, 2020 · 03c4f6e · 03c4f6e
1 parent 995a0a6
commit 03c4f6e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -21,6 +21,7 @@ jobs:
 
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v1
+        if: startsWith(github.ref, 'refs/tags/')
         with:
           version: latest
           args: release

diff --git a/main.go b/main.go
@@ -165,11 +165,14 @@ func run(ctx context.Context, provider secrets.Provider, commandSlice []string)
 			if sig != syscall.SIGCHLD {
 				// forward signal to the main process and its children
 				e := syscall.Kill(-cmd.Process.Pid, sig.(syscall.Signal))
-				log.WithFields(log.Fields{
-					"pid":  cmd.Process.Pid,
-					"path": cmd.Path,
-					"args": cmd.Args,
-				}).WithError(e).Error("failed to kill process")
+				if e != nil {
+					log.WithFields(log.Fields{
+						"pid":    cmd.Process.Pid,
+						"path":   cmd.Path,
+						"args":   cmd.Args,
+						"signal": sig,
+					}).WithError(e).Error("failed to send system signal to the process")
+				}
 			}
 		}
 	}()