Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional filter #209

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Fix additional filter #209

merged 3 commits into from
Aug 27, 2021

Conversation

stepanstipl
Copy link
Contributor

@stepanstipl stepanstipl commented Aug 27, 2021

With the introduction of filtering, we, unfortunately, broke additional kind functionality - #204.

This PR fixes the issue:

$./bin/kubent-darwin-amd64 -a AllowlistedWorkload.v1.auto.gke.io
4:02PM INF >>> Kube No Trouble `kubent` <<<
4:02PM INF version dev (git sha dev)
4:02PM INF Initializing collectors and retrieving data
4:02PM INF Target K8s version is 1.20.8-gke.900
4:02PM INF Retrieved 157 resources from collector name=Cluster
4:02PM INF Retrieved 0 resources from collector name="Helm v2"
4:02PM INF Retrieved 0 resources from collector name="Helm v3"
4:02PM INF Loaded ruleset name=custom.rego.tmpl
4:02PM INF Loaded ruleset name=deprecated-1-16.rego
4:02PM INF Loaded ruleset name=deprecated-1-22.rego
4:02PM INF Loaded ruleset name=deprecated-1-25.rego
__________________________________________________________________________________________
>>> Additional resources (custom) <<<
------------------------------------------------------------------------------------------
KIND                  NAMESPACE     NAME             API_VERSION      REPLACE_WITH (SINCE)
AllowlistedWorkload   <undefined>   cc               auto.gke.io/v1   <na> (<nil>+)
AllowlistedWorkload   <undefined>   datadog-agents   auto.gke.io/v1   <na> (<nil>+)
...

There are some related issues with output formatting discovered (#207), to be fixed separately, and it would be nice to cover this in integration test (#208).

@stepanstipl stepanstipl added the fix Fix for an issue label Aug 27, 2021
@stepanstipl stepanstipl requested a review from a user August 27, 2021 15:08
@stepanstipl stepanstipl self-assigned this Aug 27, 2021
@stepanstipl stepanstipl force-pushed the fix-additional-filter branch from 99536a9 to 5e41e00 Compare August 27, 2021 15:20
Not all results are expected to have valid versions, such as additional
resources.

fixes #204
Not all results are expected to have valid versions, such as additional
resources.

fixes #204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant