Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the GetCACaps operation handling to the SCEP servlet #541

Closed
wants to merge 1 commit into from

Conversation

borama
Copy link
Contributor

@borama borama commented Aug 29, 2020

This PR adds the GetCACaps operation to the SCEP servlet. The GetCACaps operation is defined in the new SCEP drafts and it should allow Dogtag to support SCEP clients that require it (or, as an example, we found out that some clients switch to using deprecated hash / encryption algorithms when they don't receive proper response from this operation).

I went through the current SCEP implementation in Dogtag to try to determine which features are exactly supported and which not. If I understood things correctly, Dogtag doesn't support AES in SCEP, certificate renewal (I am about to try to implement this though) and CA cert rollover (the GetNextCACert operation). Other features listed in the draft are supported and printed as the operation response in a simple text form, following the draft specification.

This is the output of calling this operation (using curl):

image

I am ready for your suggestions, thank you for considering this PR!

Update: I found out that the HTTP POST requests are not properly handled, I opened a separate PR #542 for this.

@cipherboy cipherboy requested review from ladycfu and cipherboy August 31, 2020 12:20
@ladycfu
Copy link
Contributor

ladycfu commented Feb 6, 2021

Thank you @borama I think this looks straight forward. I'm holding off on #542 (pending some more tests) for now so I'll temporarily remove "POSTPKIOperation" from the patch before I check in for you.

@cipherboy cipherboy removed their request for review February 4, 2022 01:59
@fmarco76
Copy link
Member

The commit associated on this PR seems already merged d88c48f so I am closing this.

@fmarco76 fmarco76 closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants