Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getopt deprecation warnings (part 5) #4915

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Dec 19, 2024

The following Python modules have been updated to use argparse:

  • pki.server.cli.ca
  • pki.server.cli.kra
  • pki.server.cli.ocsp
  • pki.server.cli.tks
  • pki.server.cli.tps
  • pki.server.cli.acme
  • pki.server.cli.est

@edewata edewata requested a review from fmarco76 December 19, 2024 08:44
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The new code with argparse looks much better!

@edewata
Copy link
Contributor Author

edewata commented Dec 19, 2024

@fmarco76 Thanks! There's one more PR, then I need to investigate out how to use subparser for pki-server command, so the Python lint failure probably won't disappear until January.

@edewata edewata merged commit 52cefa4 into dogtagpki:master Dec 19, 2024
158 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants