-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix container restart issue #4912
Conversation
835c2b0
to
5199563
Compare
When container are restarted with podman the restart will send the TERM signal to the entry process. Since the main entry for these container is a script running other script and waiting the signal are not propagated to the thread group making the restart hanging until a KILL signal is used but these return with an error code making the automation failing.
When a podman container restarts the network interface does not always get updated correctly, making the following communications with the container fail. Reload the network solve the problems when it is present.
Quality Gate passedIssues Measures |
The remaining errors in container related to https://github.com/fmarco76/pki/actions/runs/12394479652 These will be fixed in separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We can merge this, but does it mean we need to do this whenever we restart a container?
docker restart ca
sleep 10
docker network reload --all
I wonder if this is caused by a recent change in Docker/Podman or something else.
Not sure the reason. Running local (and I did also some test in the actions adding the -v to curl) I get no route to host from client to ca. Reloading the interfaces solve the issue. I did not find other solutions to solve this problem and not sure if it is related to the special setup we are using requiring some additional flag. I would consider this as a temporary solution for the moment. We can investigate while resolving the other container issues. |
@edewata Thanks! |
When container are restarted with podman the reestart will send the TERM signal to the entry process. Since the main entry for these container is a script running other script and waiting the singal are not propagated to the thread group making the restart hanging until a KILL signal is used but these return with an error code making the automation failing.