Add fallback for Certificate.not_valid_before/after_utc #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NSSDatabase.get_cert_info() has been modified so that it will use Certificate.not_valid_before/after_utc attributes which are available since Python Cryptography 42, otherwise it will use the deprecated not_valid_before/after then convert them into UTC.
|
|
@fmarco76 Thanks! As mentioned in Slack I'm wondering if we should have used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NSSDatabase.get_cert_info()has been modified so that it will useCertificate.not_valid_before/after_utcattributes which are available since Python Cryptography 42, otherwise it will use the deprecatednot_valid_before/afterthen convert them into UTC.https://github.com/edewata/pki/blob/python/docs/changes/v11.6.0/API-Changes.adoc