New ranges tree for legacy2 migration #4887
Conversation
| conn.add(rangesEntry); | ||
| } catch (LDAPException ldae) { | ||
| if (ldae.getLDAPResultCode() != 68) { | ||
| throw new EBaseException("Impossible create ranges object", ldae); |
There was a problem hiding this comment.
Could we append the LDAPException message to the EBaseException message to simplify troubleshooting?
| conn.add(rangeEntry); | ||
| } catch (LDAPException ldae) { | ||
| if (ldae.getLDAPResultCode() != 68) { | ||
| throw new EBaseException("Impossible access object in ranges", ldae); |
| } | ||
|
|
||
| @Override | ||
| public void execute(CommandLine cmd) throws Exception { | ||
| String newRangesName = "ranges_v2"; |
There was a problem hiding this comment.
I think ideally the default value should be set depending on the generator type, for example:
if (generator == LEGACY_2) {
newRangesName = "ranges_v2";
}
But since we only use this for SSNv2 it doesn't really matter.
| @@ -310,4 +324,71 @@ private void updateRanges(DatabaseConfig dbConfig, LdapBoundConnection conn, Str | |||
| conn.modify(serialDN, serialmod); | |||
There was a problem hiding this comment.
Here we're modifying the nextRange used by SSNv1 with a value meant for SSNv2 so the admin will need to restore it to the original value if there's a migration issue. To avoid that I'd suggest moving it to SSNv2 subtree as well (i.e. ou=ranges_v2). We can address this in a separate PR.
There was a problem hiding this comment.
Yes, this will be in separate PR!
When an instance is updated from legacy generator to the new legacy2 generator the ranges will be stored in a new tree. The default tree name is "ou=range_v2,<subsystem_base_db>". The name of the ranges entry can be customised with the option `-r` (or --range) to the command `pki-server <subsystem>-id-generator-update`.
fmarco76
force-pushed
the
newRangesSSNv2
branch
from
e84124c to
e75f0b2
Compare
|
|
@edewata Thanks! I have update following your comments. |
During migration from
legacytolegacy2generator the ranges object are not modified but entries are duplicated in a new tree with the correct format and this new tree is used for the following range allocations.The default ranges object will be
ranges_v2but the value can be modified wit the option-ror--rangeto the commandpki-server <subsystem>-id-generator-update.