Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for CA clone with sequential serial numbers #4876

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Oct 11, 2024

A new test has been added to create a CA with sequential serial numbers, create a clone with the same config, perform enrollments, and update the serial number ranges with pki ca-job-start serialNumberUpdate.

Ideally the serial numbers should be contiguous, but currently the code creates a gap between the ranges. The steps for fixing an existing gap and migrating to RSNv3 may be added later.

@edewata edewata requested a review from fmarco76 October 11, 2024 15:26
@fmarco76
Copy link
Member

@edewata it seems the new test is not associated with any workflow. Could you add to the ca clone tests

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The test seems OK but it should be linked to a workflow, as indicated in general comment. If no error after the execution then can be merged.

A new test has been added to create a CA with sequential serial
numbers, create a clone with the same config, perform enrollments,
and update the serial number ranges with pki ca-job-start
serialNumberUpdate.

Ideally the serial numbers should be contiguous, but currently
the code creates a gap between the ranges. The steps for fixing
an existing gap and migrating to RSNv3 may be added later.
@edewata
Copy link
Contributor Author

edewata commented Oct 11, 2024

@fmarco76 Oops.. missed that. Thanks! I've fixed the PR, will merge when the CI is complete.

Copy link

@edewata
Copy link
Contributor Author

edewata commented Oct 12, 2024

@fmarco76 For some reason the container tests are failing, but the new test is working fine, so I'll merge the PR. Thanks!

@edewata edewata merged commit 34150e1 into dogtagpki:master Oct 12, 2024
148 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants