Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gcc option _FORTIFY_SOURCE=3 #4687

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Use gcc option _FORTIFY_SOURCE=3 #4687

merged 1 commit into from
Mar 12, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Mar 8, 2024

The RPM spec has been updated to use gcc option _FORTIFY_SOURCE=3 since it's now required by rpminspect. The code that configures this option in CMake script has been removed to reduce dependency on CMake.

Note: For some reason rpminspect on tpsclient is still failing. That will require a separate investigation.

The RPM spec has been updated to use gcc option _FORTIFY_SOURCE=3
since it's now required by rpminspect. The code that configures
this option in CMake script has been removed to reduce dependency
on CMake.
Copy link

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Compiler options in spec file are easier to read.

I have noticed that ipa base test often fails but if re-run one or more times at the end it pass. Is this normal?

@edewata
Copy link
Contributor Author

edewata commented Mar 12, 2024

@fmarco76 Thanks!

The failures are not normal, but since they're intermittent it's hard to troubleshoot and fix. There are some tickets already for those issues:
#4680
#4683
#4677

@edewata edewata merged commit a9c211b into dogtagpki:master Mar 12, 2024
133 of 135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants