Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preop.admin.group param #4654

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Remove preop.admin.group param #4654

merged 1 commit into from
Jan 12, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jan 11, 2024

The preop.admin.group param defines the list of admin user's default groups and provides an undocumented way to customize the groups during installation, but this param can only be used under certain installation scenarios. Instead of that, it's better to use the CLI to change the groups after the installation is done.

The param has been removed and the list of admin user's default groups has been moved into PKIDeployer.setup_admin_user().

The preop.admin.group param defines the list of admin user's
default groups and provides an undocumented way to customize the
groups during installation, but this param can only be used under
certain installation scenarios. Instead of that, it's better to
use the CLI to change the groups after the installation is done.

The param has been removed and the list of admin user's default
groups has been moved into PKIDeployer.setup_admin_user().
@edewata edewata requested a review from fmarco76 January 11, 2024 16:21
Copy link

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jan 12, 2024

@fmarco76 Thanks!

@edewata edewata merged commit 6a4648b into dogtagpki:master Jan 12, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants