Fix the update to 11.5.0 #4641
Merged
Fix the update to 11.5.0 #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewata
approved these changes
Dec 14, 2023
edewata
reviewed
Dec 14, 2023
| @@ -20,12 +20,11 @@ def __init__(self): | |||
| self.message = 'Removes certs data and CSR from CS.cfg' | |||
|
|
|||
| def upgrade_instance(self, instance): | |||
|
|
|||
| instance.makedirs(instance.certs_dir, exist_ok=True) | |||
There was a problem hiding this comment.
I think we don't need this code anymore. Feel free to remove it.
Check and create the folder for every subsystem update, beside the instance update. During the update certs and csr are removed from CS.cfg file and stored in `<config>/certs` folder if they are not in the internaldb. The folder creation for the instance was done after update the subsystem generating an error and stopping the update.
|
|
@edewata Thanks! I have updated the commit following your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check and create the folder for every subsystem update, beside the instance update.
During the update certs and csr are removed from CS.cfg file and stored in
<config>/certsfolder if they are not in the internaldb.The folder creation for the instance was done after update the subsystem generating an error and stopping the update.